Skip to content
This repository was archived by the owner on Apr 2, 2026. It is now read-only.

fix: prevent NPE when checking requester pays status#850

Merged
cojenco merged 1 commit intogoogleapis:mainfrom
lbergelson:lb_fix_npe
Mar 9, 2022
Merged

fix: prevent NPE when checking requester pays status#850
cojenco merged 1 commit intogoogleapis:mainfrom
lbergelson:lb_fix_npe

Conversation

@lbergelson
Copy link
Copy Markdown
Contributor

Fixes a NullPointerException introduced in #841 which occured when trying
to check the the requesterPays status of a file while authenticated with an
invalid service account.

Refs: #849, #841

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #849 ☕️

Fixes a NullPointerException introduced in googleapis#841 which occured when trying
to check the the requesterPays status of a file while authenticated with an
invalid service account.

Refs: googleapis#849, googleapis#841
@lbergelson lbergelson requested a review from a team March 8, 2022 22:02
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage-nio API. label Mar 8, 2022
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2022
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 9, 2022
@cojenco cojenco merged commit ce50209 into googleapis:main Mar 9, 2022
lbergelson added a commit to broadinstitute/gatk that referenced this pull request Mar 18, 2022
* The previous attempt to fix requester pays didn't fix it in many cases.
This incorporates a newer version of the NIO library with several patches to fix
edge cases we were hitting.
  * googleapis/java-storage-nio#850
  * googleapis/java-storage-nio#856
  * googleapis/java-storage-nio#857
* upgrade com.google.cloud:google-cloud-nio:0.123.23 ->0.123.25
* fixes #7716
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/java-storage-nio API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NPE in requesterPays check if credentials don't match provided user project

4 participants