feat: add @BetaApi BlobWriteSession#parallelCompositeUpload#2239
Merged
BenWhitehead merged 4 commits intomainfrom Oct 3, 2023
Merged
feat: add @BetaApi BlobWriteSession#parallelCompositeUpload#2239BenWhitehead merged 4 commits intomainfrom
BenWhitehead merged 4 commits intomainfrom
Conversation
71129ed to
8fa2602
Compare
e9e9769 to
0a6919b
Compare
69a6e47 to
632d51e
Compare
BenWhitehead
commented
Oct 2, 2023
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Outdated
Show resolved
Hide resolved
a5327f3 to
3e9423e
Compare
Base automatically changed from
write-acceleration/m3/7/pcu-wbc-del-onError
to
main
October 2, 2023 21:59
sydney-munro
reviewed
Oct 3, 2023
Contributor
sydney-munro
left a comment
There was a problem hiding this comment.
Logic change alright for this PR but would be helpful to separate docs and logic in the future.
google-cloud-storage/src/main/java/com/google/cloud/storage/BlobWriteSessionConfigs.java
Outdated
Show resolved
Hide resolved
| * <td> | ||
| * <ol> | ||
| * <li> | ||
| * Performing parallel composite uploads costs more money. |
Contributor
There was a problem hiding this comment.
nit: can we draw attention to this section. maybe with a heading like drawbacks or something
Collaborator
Author
There was a problem hiding this comment.
In #2242 I'm reordering the columns to move this column of the table more left to make it more prominent.
Because this text is in a table we can't really add a heading to it. Secondarily, since the table is already struggling with horizontal space on cloud.google.com[1] I don't know that adding another column would surface it better or get it hidden more.
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageImpl.java
Show resolved
Hide resolved
sydney-munro
approved these changes
Oct 3, 2023
0b4cc1e to
48428b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose public api to allow selection and configuration of new Parallel Composite Upload BlobWriteSession strategy