feat: Follow-up CLI Improvements#2184
Merged
gcf-merge-on-green[bot] merged 2 commits intomainfrom Aug 30, 2023
Merged
Conversation
Contributor
sydney-munro
commented
Aug 29, 2023
- Rename Workload1.java to W1R3 to prevent future confusion when it is used for other workloads
- Take in temporary directory as a CLI argument
- Utilize PrintWrite instead of System.out directly
1. Rename Workload1.java to W1R3 to prevent future confusion when it is used for other workloads 2. Take in temporary directory as a CLI argument 3. Utilize PrintWrite instead of System.out directly
BenWhitehead
approved these changes
Aug 30, 2023
Collaborator
BenWhitehead
left a comment
There was a problem hiding this comment.
Feel free to merge after enabling autoFlush on the PrintWriter
...arking/src/main/java/com/google/cloud/storage/benchmarking/StorageSharedBenchmarkingCli.java
Outdated
Show resolved
Hide resolved
storage-shared-benchmarking/src/main/java/com/google/cloud/storage/benchmarking/W1R3.java
Outdated
Show resolved
Hide resolved
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.