fix: plumb GrpcInterceptorProvider to constructed InstantiatingGrpcChannelProvider#2031
Merged
BenWhitehead merged 2 commits intomainfrom May 23, 2023
Merged
fix: plumb GrpcInterceptorProvider to constructed InstantiatingGrpcChannelProvider#2031BenWhitehead merged 2 commits intomainfrom
BenWhitehead merged 2 commits intomainfrom
Conversation
JesseLovelace
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a default Noop implementation which will only be overridden when a non-noop instance is provided.
Adding a new argument to GrpcStorageOptions was done intentionally such that if/when we need to register our own interceptor we can do so by unioning our provider along with the instance provided to the options. (com.google.api.gax.grpc.InstantiatingGrpcChannelProvider.Builder#setInterceptorProvider will perform an explicit set, overriding any value that might have been previously specified)