feat: Custom Placement Config Dual Region Support#1470
Merged
sydney-munro merged 12 commits intomainfrom Jul 12, 2022
Merged
Conversation
BenWhitehead
requested changes
Jun 23, 2022
Collaborator
BenWhitehead
left a comment
There was a problem hiding this comment.
Looks like some tests are failing and need to be fixed before merging.
I had one question above for BucketInfo.
@danielbankhead Do you know if this same change is going to be made for the gRPC protos?
We need to keep the protos in mind when designing our new model classes.
Contributor
|
@sydney-munro, @BenWhitehead this PR should be testable/verifiable after a config push deployment (ETA July 1). |
This reverts commit 794e81e.
1b387d0 to
e49b5c3
Compare
BenWhitehead
approved these changes
Jul 12, 2022
Collaborator
BenWhitehead
left a comment
There was a problem hiding this comment.
Feel free to merge when tests are all passing.
sydney-munro
added a commit
that referenced
this pull request
Oct 12, 2022
* 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1428 ☕️
Will follow up with sample update.
If you write sample code, please follow the samples format.