Skip to content

docs: Adding Samples for Add/Remove Bucket Default Owner#1260

Merged
sydney-munro merged 2 commits intomainfrom
default-acl
Feb 17, 2022
Merged

docs: Adding Samples for Add/Remove Bucket Default Owner#1260
sydney-munro merged 2 commits intomainfrom
default-acl

Conversation

@sydney-munro
Copy link
Copy Markdown
Contributor

@sydney-munro sydney-munro commented Feb 17, 2022 •
edited by BenWhitehead
Loading

Internal issues:

@sydney-munro sydney-munro added api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Feb 17, 2022
@sydney-munro sydney-munro self-assigned this Feb 17, 2022
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Feb 17, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@sydney-munro sydney-munro added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 17, 2022
@sydney-munro sydney-munro requested review from a team February 17, 2022 20:00
@BenWhitehead
Copy link
Copy Markdown
Collaborator

BenWhitehead commented Feb 17, 2022

LGTM, if either @JesseLovelace or @frankyn could also give this a quick review that'd be great.

@sydney-munro sydney-munro merged commit 7223626 into main Feb 17, 2022
@sydney-munro sydney-munro deleted the default-acl branch February 17, 2022 23:27
@release-please release-please Bot mentioned this pull request Feb 17, 2022
Merged
@release-please release-please Bot mentioned this pull request Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

+1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sydney-munro sydney-munro

Labels

api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sydney-munro @BenWhitehead @frankyn @yoshi-kokoro