Revert "feat: attemp DirectPath by default"#520
Merged
kolea2 merged 1 commit intogoogleapis:masterfrom Nov 10, 2020
Merged
Conversation
This reverts commit 89c622d.
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
============================================
- Coverage 81.32% 81.26% -0.06%
- Complexity 1128 1129 +1
============================================
Files 106 106
Lines 7042 7047 +5
Branches 368 370 +2
============================================
Hits 5727 5727
- Misses 1117 1121 +4
- Partials 198 199 +1
Continue to review full report at Codecov.
|
Merged
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 10, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.17.2](https://www.github.com/googleapis/java-bigtable/compare/v1.17.1...v1.17.2) (2020-11-10) ### Bug Fixes * readRowSettings use manual readRows settings instead of gapics ([#494](https://www.github.com/googleapis/java-bigtable/issues/494)) ([0ef7c5d](https://www.github.com/googleapis/java-bigtable/commit/0ef7c5d4aacacd2030a52efc148ead457719a927)) ### Reverts * Revert "feat: attemp DirectPath by default (#467)" (#520) ([b33b0fc](https://www.github.com/googleapis/java-bigtable/commit/b33b0fc1b5478934298db317c1168c1e9dc20599)), closes [#467](https://www.github.com/googleapis/java-bigtable/issues/467) [#520](https://www.github.com/googleapis/java-bigtable/issues/520) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
mutianf
pushed a commit
to mutianf/java-bigtable
that referenced
this pull request
Nov 12, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.17.2](https://www.github.com/googleapis/java-bigtable/compare/v1.17.1...v1.17.2) (2020-11-10) ### Bug Fixes * readRowSettings use manual readRows settings instead of gapics ([googleapis#494](https://www.github.com/googleapis/java-bigtable/issues/494)) ([0ef7c5d](https://www.github.com/googleapis/java-bigtable/commit/0ef7c5d4aacacd2030a52efc148ead457719a927)) ### Reverts * Revert "feat: attemp DirectPath by default (googleapis#467)" (googleapis#520) ([b33b0fc](https://www.github.com/googleapis/java-bigtable/commit/b33b0fc1b5478934298db317c1168c1e9dc20599)), closes [googleapis#467](https://www.github.com/googleapis/java-bigtable/issues/467) [googleapis#520](https://www.github.com/googleapis/java-bigtable/issues/520) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ad548
pushed a commit
to ad548/java-bigtable
that referenced
this pull request
Mar 13, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.17.2](https://www.github.com/googleapis/java-bigtable/compare/v1.17.1...v1.17.2) (2020-11-10) ### Bug Fixes * readRowSettings use manual readRows settings instead of gapics ([googleapis#494](https://www.github.com/googleapis/java-bigtable/issues/494)) ([0ef7c5d](https://www.github.com/googleapis/java-bigtable/commit/0ef7c5d4aacacd2030a52efc148ead457719a927)) ### Reverts * Revert "feat: attemp DirectPath by default (googleapis#467)" (googleapis#520) ([b33b0fc](https://www.github.com/googleapis/java-bigtable/commit/b33b0fc1b5478934298db317c1168c1e9dc20599)), closes [googleapis#467](https://www.github.com/googleapis/java-bigtable/issues/467) [googleapis#520](https://www.github.com/googleapis/java-bigtable/issues/520) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #467
After this PR, gax-java relies on
ComputeEngineCredentialsto determine whether the client should useComputeEngineChannelBuilder: https://github.com/googleapis/gax-java/blob/master/gax-grpc/src/main/java/com/google/api/gax/grpc/InstantiatingGrpcChannelProvider.java#L253However,
ComputeEngineCredentialshas different assumptions thanComputeEngineChannelBuilder, which causesComputeEngineChannelBuilderto fail on AppEngine: grpc/grpc-java#7604.We need to rollback this PR, and make the fix in gax-java, and then roll-forward again.
@apolcyn
@mohanli-ml
@igorbernstein2
@mgarolera