Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

fix: fix WriteToDefaultStream example code to close the client properly#2433

Merged
GaoleMeng merged 2 commits into
googleapis:mainfrom
GaoleMeng:main
Mar 7, 2024
Merged

fix: fix WriteToDefaultStream example code to close the client properly#2433
GaoleMeng merged 2 commits into
googleapis:mainfrom
GaoleMeng:main

Conversation

@GaoleMeng

@GaoleMeng GaoleMeng commented Mar 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Client being created has to be properly closed, otherwise during garbage
collection an error will be reported showing channel not shutdown

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@conventional-commit-lint-gcf

conventional-commit-lint-gcf Bot commented Mar 7, 2024 •
edited
Loading

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Mar 7, 2024
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 7, 2024
@GaoleMeng GaoleMeng force-pushed the main branch 2 times, most recently from 7d2912b to ef89a67 Compare March 7, 2024 07:21
@GaoleMeng
fix: fix channel not shut down properly exception.
0a56e0e 
Client being created has to be properly closed, otherwise during garbage
collection an error will be reported showing channel not shutdown
properly
@GaoleMeng GaoleMeng changed the title [not reviewable] fix: fix WriteToDefaultStream example code to close the client properly fix: fix WriteToDefaultStream example code to close the client properly Mar 7, 2024
@GaoleMeng GaoleMeng changed the title fix: fix WriteToDefaultStream example code to close the client properly Fix WriteToDefaultStream example code to close the client properly Mar 7, 2024
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 7, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 7, 2024
@GaoleMeng GaoleMeng requested review from a team and tswast March 7, 2024 17:51
@GaoleMeng GaoleMeng changed the title Fix WriteToDefaultStream example code to close the client properly fix: fix WriteToDefaultStream example code to close the client properly Mar 7, 2024
@GaoleMeng GaoleMeng merged commit d8a52f8 into googleapis:main Mar 7, 2024
@release-please release-please Bot mentioned this pull request Mar 7, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tswast tswast Awaiting requested review from tswast

1 more reviewer

@yirutang yirutang yirutang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GaoleMeng @yirutang