feat!: use table name create default write stream issue fix#2119
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
|
@MrDLontheway Please sign the CLA |
done |
| private static final String streamPatternString = | ||
| "(projects/[^/]+/datasets/[^/]+/tables/[^/]+)/streams/[^/]+"; | ||
| private static final String tablePatternString = "(projects/[^/]+/datasets/[^/]+/tables/[^/]+)"; | ||
| private static final String defaultTablePatternString = tablePatternString + "/_default"; |
There was a problem hiding this comment.
should be defaultStream instead of defaultTable?
|
I don't know why this is marked as breaking change... |
|
The "!" in the "feat!" conventional commit title. |
Hoops, will pay attention to this in code review later. Thanks for the reply. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.