enhancement(automl): support for passing project to 'GcsClient' #9299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like you need to change the commit message (rather than the PR title): https://github.com/googleapis/google-cloud-python/pull/9299/checks?check_run_id=236270561
|
…ablesClient passing the default project and credentials
…are passed properly
Contributor
Author
I've updated the commit messages, but the checks haven't run again. Do I need to make a trivial commit or is there another way to force the checks to run again? |
…blesClient passing the default project and credentials
Contributor
Author
|
@tseaver Should I also update the type on the commit messages from fix to enhancement? |
tseaver
reviewed
Sep 26, 2019
| self.client = storage.Client() | ||
|
|
||
| self.bucket_name = bucket_name | ||
| self.project = project |
Contributor
Author
There was a problem hiding this comment.
Removed and updated the docstring. Thanks!
busunkim96
reviewed
Sep 27, 2019
tseaver
approved these changes
Sep 27, 2019
…hanged string to str
tseaver
approved these changes
Oct 1, 2019
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
GcsClient.__init__takes an optional project parameter and passes it to thestorage.Clientconstructor.GcsClientI had a little trouble testing that parameters were passed to the constructors for
GcsClientandstorage.Client. I tried various combinations of mock and patch, but evenMagicMockdoesn't support mocking__init__(). Any suggestions on better approaches would be appreciated.