fix: make google-cloud-monitoring tests work without mock#12317
Merged
parthea merged 2 commits intoFeb 15, 2024
Conversation
https://pypi.org/project/mock/ library is not needed anymore on modern Python installation, since it is now part of the Python standard library, available as `unittest.mock`. Reuse approach used in generated `tests/unit/gapic/monitoring_v3/` for manually written `tests/unit/test_query.py`. This issue and solution was found as a part of packaging the library for Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=2263960.
parthea
approved these changes
Feb 15, 2024
Contributor
|
Thanks for the fix @rominf ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://pypi.org/project/mock/ library is not needed anymore on modern
Python installation, since it is now part of the Python standard
library, available as
unittest.mock.Reuse approach used in generated
tests/unit/gapic/monitoring_v3/formanually written
tests/unit/test_query.py.This issue and solution was found as a part of packaging the library for
Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=2263960.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #12316 🦕