Bigtable: Adding ABORTED as default retry code#6214
Merged
igorbernstein2 merged 4 commits intogoogleapis:masterfrom Sep 5, 2019
Merged
Bigtable: Adding ABORTED as default retry code#6214igorbernstein2 merged 4 commits intogoogleapis:masterfrom
igorbernstein2 merged 4 commits intogoogleapis:masterfrom
Conversation
- Added StatusCode.ABORTED as default retry code to bigtable. - Updated test case to verify the same.
igorbernstein2
suggested changes
Sep 4, 2019
Contributor
igorbernstein2
left a comment
There was a problem hiding this comment.
We should only retry ABORTED on ReadRows
...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java
Show resolved
Hide resolved
...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #6214 +/- ##
============================================
+ Coverage 47.53% 47.53% +<.01%
- Complexity 27472 27487 +15
============================================
Files 2534 2534
Lines 274924 274928 +4
Branches 31408 31403 -5
============================================
+ Hits 130681 130685 +4
Misses 134610 134610
Partials 9633 9633
Continue to review full report at Codecov.
|
...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java
Show resolved
Hide resolved
...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java
Outdated
Show resolved
Hide resolved
igorbernstein2
approved these changes
Sep 4, 2019
Contributor
igorbernstein2
left a comment
There was a problem hiding this comment.
LGTM and thanks for dealing with my nitpicks :)
|
Is it possible that the same issue is present in the Python google client library for bigtable and has not been resolved yet? Or that in the Python google client library it is not possible to retry such failures? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6205
StatusCode.ABORTEDas default retry code to bigtable.