Bigtable: RowMutationEntry#create for unsafe mutation creation#6211
Merged
rahulKQL merged 2 commits intogoogleapis:masterfrom Sep 5, 2019
Merged
Bigtable: RowMutationEntry#create for unsafe mutation creation#6211rahulKQL merged 2 commits intogoogleapis:masterfrom
rahulKQL merged 2 commits intogoogleapis:masterfrom
Conversation
Introducing `RowMutationEntry#create(key, mutation)` so that mutation with server side timestamp can be created using `RowMutationEntry`. This shall be used for HBase batching with server side timestamp([here](https://github.com/googleapis/java-bigtable-hbase/blob/master/bigtable-client-core-parent/bigtable-hbase/src/main/java/com/google/cloud/bigtable/hbase/adapters/HBaseRequestAdapter.java#L332-L335)).
igorbernstein2
suggested changes
Sep 4, 2019
Contributor
igorbernstein2
left a comment
There was a problem hiding this comment.
I think I'd prefer RowMutationEntry.createUnsafe(key)
Contributor
Author
|
@igorbernstein2 Thanks for the suggestion, I have updated method the same name. Please have a fresh look. |
rahulKQL
commented
Sep 4, 2019
...-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/RowMutationEntry.java
Show resolved
Hide resolved
igorbernstein2
approved these changes
Sep 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #6211 +/- ##
============================================
- Coverage 47.53% 47.53% -0.01%
- Complexity 27472 27488 +16
============================================
Files 2534 2534
Lines 274924 274925 +1
Branches 31408 31403 -5
============================================
Hits 130681 130681
- Misses 134610 134611 +1
Partials 9633 9633
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing
RowMutationEntry#create(key, mutation)so that mutation can be passed directly toRowMutationEntry.This shall be used for HBase batching with the server-side timestamp(here).