Skip to content

feat: [maps-places] new module for maps-places#9420

Merged
JoeWang1127 merged 7 commits intomainfrom
new_module_java-maps-places
Nov 3, 2023
Merged

feat: [maps-places] new module for maps-places#9420
JoeWang1127 merged 7 commits intomainfrom
new_module_java-maps-places

Conversation

@alicejli
Copy link
Contributor

@alicejli alicejli commented May 9, 2023

Updated #9419 to match other maps modules.

Command to execute:

python3.9 generation/new_client/new-client.py generate \
  --api_shortname=maps-places \
  --proto-path=google/maps/places \
  --name-pretty="Places API (New)" \
  --product-docs="https://developers.google.com/maps/documentation/places/web-service/" \
  --api-description="The Places API allows developers to access a variety of search and
    retrieval endpoints for a Place." \
  --api-id=places.googleapis.com \
  --cloud-api=false \
  --requires-billing=true \
  --distribution-name="com.google.maps:google-maps-places"

@snippet-bot
Copy link

snippet-bot bot commented May 9, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 7 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@alicejli alicejli mentioned this pull request May 9, 2023
Closed
@alicejli alicejli requested a review from suztomo May 9, 2023 20:17
meltsufin
meltsufin reviewed May 10, 2023
View reviewed changes
@alicejli alicejli added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 10, 2023
@alicejli
Copy link
Contributor Author

alicejli commented May 10, 2023

Adding "do not merge" until the team confirms on b/281587773 they are okay with releasing.

@JoeWang1127 JoeWang1127 added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Nov 2, 2023
@JoeWang1127 JoeWang1127 added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 3, 2023
@JoeWang1127 JoeWang1127 added owlbot:run Add this label to trigger the Owlbot post processor. owl-bot-copy labels Nov 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 3, 2023
@JoeWang1127 JoeWang1127 merged commit 7e76fbc into main Nov 3, 2023
@JoeWang1127 JoeWang1127 deleted the new_module_java-maps-places branch November 3, 2023 15:30
@release-please release-please bot mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meltsufin meltsufin meltsufin left review comments

@burkedavison burkedavison burkedavison approved these changes

@suztomo suztomo Awaiting requested review from suztomo

Assignees

No one assigned

Labels

owl-bot-copy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alicejli @meltsufin @burkedavison @JoeWang1127