-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Datastore: fix NullPointerException in TransactionExceptionHandler (#2256) #2271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
Changes Unknown when pulling 0d90aed on cmaan:master into ** on GoogleCloudPlatform:master**. |
|
I signed it! |
|
@garrettjonesgoogle I'm not sure why @googlebot complains, I got an organizational CLA signed before opening the pull request, the email address should be the same for all of commit, github, as well as google group - anything else I could be missing? |
|
Hmm, try adding additional e-mails to your github account that you might have possibly used somewhere in the process. |
e4f3b20 to
3ee8ab0
Compare
|
Ah, this seems to be the mangled link @googlebot is talking about: https://opensource.google.com/docs/cla/#troubleshoot
Someone should update @googlebot's message. |
|
Changes Unknown when pulling e4f3b20 on cmaan:master into ** on GoogleCloudPlatform:master**. |
|
Changes Unknown when pulling 7a54525 on cmaan:master into ** on GoogleCloudPlatform:master**. |
|
Changes Unknown when pulling 3ee8ab0 on cmaan:master into ** on GoogleCloudPlatform:master**. |
|
Changes Unknown when pulling 7a54525 on cmaan:master into ** on GoogleCloudPlatform:master**. |
|
I signed it! |
|
CLAs look good, thanks! |
neozwu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix NullPointerException caused by user exceptions nested in datastore transactions (#2256)