Skip to content

Conversation

@cmaan
Copy link

@cmaan cmaan commented Jul 25, 2017

fix NullPointerException caused by user exceptions nested in datastore transactions (#2256)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 25, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0d90aed on cmaan:master into ** on GoogleCloudPlatform:master**.

@cmaan
Copy link
Author

cmaan commented Jul 25, 2017

I signed it!

@cmaan
Copy link
Author

cmaan commented Jul 26, 2017

@garrettjonesgoogle I'm not sure why @googlebot complains, I got an organizational CLA signed before opening the pull request, the email address should be the same for all of commit, github, as well as google group - anything else I could be missing?

@garrettjonesgoogle
Copy link
Member

Hmm, try adding additional e-mails to your github account that you might have possibly used somewhere in the process.

@cmaan cmaan force-pushed the master branch 3 times, most recently from e4f3b20 to 3ee8ab0 Compare July 26, 2017 16:40
@cmaan
Copy link
Author

cmaan commented Jul 26, 2017

Ah, this seems to be the mangled link @googlebot is talking about: https://opensource.google.com/docs/cla/#troubleshoot

If the contributor is covered by a corporate CLA, make sure that the corporation is listed at http://linkremoved/. If it’s not, it simply may not have been processed yet, which typically takes a few days. If you think it’s taking longer than it should, email emailremoved@ to check the status. [sic]

Someone should update @googlebot's message.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e4f3b20 on cmaan:master into ** on GoogleCloudPlatform:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7a54525 on cmaan:master into ** on GoogleCloudPlatform:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3ee8ab0 on cmaan:master into ** on GoogleCloudPlatform:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7a54525 on cmaan:master into ** on GoogleCloudPlatform:master**.

@cmaan
Copy link
Author

cmaan commented Jul 31, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 31, 2017
@neozwu neozwu self-requested a review August 1, 2017 20:43
Copy link
Contributor

@neozwu neozwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neozwu neozwu merged commit c25af8d into googleapis:master Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants