Skip to content

make one Tuple class aross all the projects #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
neozwu merged 1 commit into from
Apr 25, 2017
Merged

make one Tuple class aross all the projects #1992

neozwu merged 1 commit into from
Apr 25, 2017

Conversation

@neozwu
Copy link
Contributor

@neozwu neozwu commented Apr 25, 2017

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 25, 2017
@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Apr 25, 2017

LGTM - we'll want to do another rc release with this before 1.0.0

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Apr 25, 2017

Approving an early merge because the change is purely syntactic and all linux tests have passed.

@neozwu neozwu merged commit c3d18ff into googleapis:master Apr 25, 2017
@coveralls
Copy link

coveralls commented Apr 25, 2017

Coverage Status

Coverage decreased (-0.02%) to 81.04% when pulling ca11b57 on neozwu:make-common-tuple into 50e37e6 on GoogleCloudPlatform:master.

@garrettjonesgoogle garrettjonesgoogle mentioned this pull request Apr 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@neozwu @garrettjonesgoogle @coveralls @googlebot