Skip to content

Expose BigQuery Dataset labels #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
garrettjonesgoogle merged 1 commit into from
Jun 2, 2017
Merged

Expose BigQuery Dataset labels #1990

garrettjonesgoogle merged 1 commit into from
Jun 2, 2017

Conversation

@rouzwawi
Copy link

@rouzwawi rouzwawi commented Apr 25, 2017

This PR propagates the labels map from the underlying com.google.api.services.bigquery.model.Dataset payload into DatasetInfo. It also adds a setLabels(Map<String, String>) method to the corresponding builders.

Furthermore, it adds a LABELS value to the DatasetField enum.

It does not change anything related to BigQuery Tables.

This should resolve part of #1525

@googlebot
Copy link

googlebot commented Apr 25, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Apr 25, 2017
@rouzwawi
Copy link
Author

rouzwawi commented Apr 25, 2017

I believe Spotify should already have a signed CLA.

@googlebot
Copy link

googlebot commented Apr 25, 2017

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 25, 2017
@coveralls
Copy link

coveralls commented Apr 25, 2017

Coverage Status

Changes Unknown when pulling 8c0e636 on rouzwawi:master into ** on GoogleCloudPlatform:master**.

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Apr 25, 2017

We will wait until we have moved Datastore/Storage/Logging to 1.0.0 before looking at this.

@coveralls
Copy link

coveralls commented Apr 25, 2017

Coverage Status

Changes Unknown when pulling 6bb3250 on rouzwawi:master into ** on GoogleCloudPlatform:master**.

@rouzwawi
Copy link
Author

rouzwawi commented Apr 25, 2017

@garrettjonesgoogle do you have a rough timeline for when that will happen?

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Apr 25, 2017

It's scheduled for today.

@garrettjonesgoogle garrettjonesgoogle merged commit 6b89ff9 into googleapis:master Jun 2, 2017
@NicolaSpreafico
Copy link

NicolaSpreafico commented Feb 6, 2018

Hello, I can see implementation for Datasets, how about Tables?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rouzwawi @googlebot @coveralls @garrettjonesgoogle @NicolaSpreafico