Skip to content

Remove guava from surface #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaelbausor merged 4 commits into from
Apr 21, 2017
Merged

Remove guava from surface #1960

michaelbausor merged 4 commits into from
Apr 21, 2017

Conversation

@michaelbausor
Copy link
Contributor

@michaelbausor michaelbausor commented Apr 21, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 21, 2017
garrettjonesgoogle
garrettjonesgoogle reviewed Apr 21, 2017
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, although your description says "WIP"

google-cloud-core/src/main/java/com/google/cloud/BaseWriteChannel.java Outdated
builder.append(getClass().getSimpleName())
.append("{");
String nextSeparator = "";
for(ValueHolder valueHolder : toStringHelper()) {

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

coveralls commented Apr 21, 2017

Coverage Status

Coverage decreased (-0.06%) to 80.826% when pulling 052e31e on michaelbausor:remove-guave into 4e080f1 on GoogleCloudPlatform:master.

@michaelbausor michaelbausor changed the title WIP: Remove guava from surface Remove guava from surface Apr 21, 2017
@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Apr 21, 2017

LGTM

@michaelbausor michaelbausor merged commit fb68318 into googleapis:master Apr 21, 2017
@michaelbausor michaelbausor deleted the remove-guave branch April 21, 2017 16:16
@coveralls
Copy link

coveralls commented Apr 21, 2017

Coverage Status

Coverage decreased (-0.06%) to 80.826% when pulling edfe20c on michaelbausor:remove-guave into 4e080f1 on GoogleCloudPlatform:master.

@vkedia vkedia mentioned this pull request May 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michaelbausor @coveralls @garrettjonesgoogle @googlebot