Skip to content

Marking some core types @BetaApi and @InternalApi #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
garrettjonesgoogle merged 2 commits into from
Apr 18, 2017
Merged

Marking some core types @BetaApi and @InternalApi #1933

garrettjonesgoogle merged 2 commits into from
Apr 18, 2017

Conversation

@garrettjonesgoogle
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle commented Apr 17, 2017

Types that will go GA:

  • spi/ServiceRpcFactory
  • BaseService
  • BaseServiceException
  • BaseWriteChannel
  • BatchResult
  • ExceptionHandler
  • FieldSelector
  • GcpLaunchStage
  • HttpTransportOptions
  • Identity
  • MonitoredResource
  • MonitoredResourceDescriptor
  • NoCredentials
  • Policy
  • ReadChannel
  • Restorable
  • RestorableState
  • RetryHelper
  • Role
  • Service
  • ServiceDefaults
  • ServiceFactory
  • ServiceOptions
  • ServiceRpc
  • Timestamp
  • TransportOptions
  • WriteChannel

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 17, 2017
michaelbausor
michaelbausor reviewed Apr 17, 2017
View reviewed changes
google-cloud-core/src/main/java/com/google/cloud/GrpcTransportOptions.java Outdated
* Class representing service options for those services that use gRPC as the transport
* layer.
*/
@BetaApi

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle
Copy link
Member Author

garrettjonesgoogle commented Apr 17, 2017

Updated, PTAL

@michaelbausor
Copy link
Contributor

michaelbausor commented Apr 17, 2017

LGTM once test issues are resolved

@coveralls
Copy link

coveralls commented Apr 18, 2017

Coverage Status

Changes Unknown when pulling af2e431 on garrettjonesgoogle:nobranch into ** on GoogleCloudPlatform:master**.

@garrettjonesgoogle garrettjonesgoogle merged commit eec31d2 into googleapis:master Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@michaelbausor michaelbausor michaelbausor left review comments

@shinfan shinfan shinfan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@garrettjonesgoogle @michaelbausor @coveralls @shinfan @googlebot