pubsub: make Subscriber logs less chatty #1748

pongad · 2017-03-14T05:31:48Z

Also use text formatting so we don't unnecessarily allocate
Strings when not logging.

Also use text formatting so we don't unnecessarily allocate Strings when not logging. Fixes #1686.

coveralls · 2017-03-14T05:44:37Z

Changes Unknown when pulling 419708f on pongad:subscriber-log-level into ** on GoogleCloudPlatform:master**.

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/MessageDispatcher.java

    Instant expiration = now.plus(messageDeadlineSeconds * 1000);
-    logger.log(Level.INFO, "Received " + responseMessages.size() + " messages at " + now);
+    logger.log(
+        Level.FINER, "Received {0} messages at {1}", new Object[] {responseMessages.size(), now});


google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/MessageDispatcher.java

-              + ", padding: "
-              + ackExpirationPadding);
+          Level.FINER,
+          "Running alarm sent outstanding acks, at time: {0}, with cutover time: {1}, padding {2}",


...e-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PollingSubscriberConnection.java

  @Override
  protected void doStart() {
-    logger.log(Level.INFO, "Starting subscriber.");
+    logger.log(Level.FINE, "Starting subscriber.");


lesv

I agree w/ Garrett here - one time things are fine at INFO; I've suggested some shorthand, feel free to ignore.

...e-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PollingSubscriberConnection.java

  @Override
  protected void doStart() {
-    logger.log(Level.INFO, "Starting subscriber.");
+    logger.log(Level.FINE, "Starting subscriber.");


...cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/StreamingSubscriberConnection.java

  @Override
  protected void doStart() {
-    logger.log(Level.INFO, "Starting subscriber.");
+    logger.log(Level.FINE, "Starting subscriber.");


...cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/StreamingSubscriberConnection.java

    @Override
    public void onCompleted() {
-      logger.log(Level.INFO, "Streaming pull terminated successfully!");
+      logger.log(Level.FINE, "Streaming pull terminated successfully!");


coveralls · 2017-03-15T02:18:49Z

Changes Unknown when pulling a0628d2 on pongad:subscriber-log-level into ** on GoogleCloudPlatform:master**.

pongad · 2017-03-15T02:53:18Z

@lesv @garrettjonesgoogle PTAL

garrettjonesgoogle · 2017-03-15T03:07:41Z

LGTM

pongad requested review from garrettjonesgoogle and lesv March 14, 2017 05:31

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2017

pongad changed the title ~~logging: make Subscriber logs less chatty~~ pubsub: make Subscriber logs less chatty Mar 14, 2017

pubsub: make Subscriber logs less chatty

419708f

Also use text formatting so we don't unnecessarily allocate Strings when not logging. Fixes #1686.

garrettjonesgoogle reviewed Mar 14, 2017

View reviewed changes

lesv reviewed Mar 14, 2017

View reviewed changes

pr comment

a0628d2

pongad merged commit d4be5e5 into googleapis:master Mar 15, 2017

pongad deleted the subscriber-log-level branch March 15, 2017 03:08

pubsub: make Subscriber logs less chatty #1748

pubsub: make Subscriber logs less chatty #1748

Uh oh!

Conversation

pongad commented Mar 14, 2017

Uh oh!

coveralls commented Mar 14, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

lesv left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Mar 15, 2017

Uh oh!

pongad commented Mar 15, 2017

Uh oh!

garrettjonesgoogle commented Mar 15, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants