feat: [privilegedaccessmanager] new module for privilegedaccessmanager#11041
Merged
Conversation
suztomo
approved these changes
Jul 31, 2024
suztomo
left a comment
Member
There was a problem hiding this comment.
Approving. The API description can be shorter.
| name_pretty: Privileged Access Manager API | ||
| product_documentation: | ||
| https://cloud.google.com/java/docs/reference/google-cloud-privilegedaccessmanager/latest/overview | ||
| api_description: Privileged Access Manager (PAM) helps you on your journey towards |
Member
There was a problem hiding this comment.
Use the first sentence to keep it concise, as per https://github.com/googleapis/google-cloud-java/blob/main/generation/new_client_hermetic_build/README.md#api-description-api_description
Member
|
Closing and re-opening to retrigger the header check |
Member
|
Failed CI from |
lqiu96
added a commit
that referenced
this pull request
Jul 7, 2025
#11041) * feat: [privilegedaccessmanager] new module for privilegedaccessmanager * chore: generate libraries at Tue Jul 30 21:53:53 UTC 2024 * chore: Update API Description --------- Co-authored-by: Lawrence Qiu <lawrenceqiu@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated by @lqiu96 via generate_new_client_hermetic_build.yaml
Command used: