feat: [Many APIs] Add an API method for reordering firewall policies#10378
Merged
feat: [Many APIs] Add an API method for reordering firewall policies#10378
Conversation
Contributor
|
Closing this as something went awry here. The PR never made it out of Draft mode because Owlbot post-processor was not able to run successfully on this PR (likely because it was too many files). Owlbot should regenerate what it needs in a new PR. |
Contributor
Author
|
Owl bot is regenerating pull request 10378... |
Contributor
|
I think my hypothesis was incorrect - #10382 is failing unit tests because I suspect it relies on updates made in this PR. Reopening this. |
PiperOrigin-RevId: 607015517 Source-Link: googleapis/googleapis@c43e216 Source-Link: https://github.com/googleapis/googleapis-gen/commit/71c27adc96b0c80093b4a413815bd93943196bb2 Copy-Tag: eyJwIjoiamF2YS1jbG91ZGJ1aWxkLy5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0= Copy-Tag: eyJwIjoiamF2YS1jbG91ZHF1b3Rhcy8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9 Copy-Tag: eyJwIjoiamF2YS1jbG91ZHN1cHBvcnQvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ== Copy-Tag: eyJwIjoiamF2YS1jb21wdXRlLy5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0= Copy-Tag: eyJwIjoiamF2YS1jb250YWluZXIvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ== Copy-Tag: eyJwIjoiamF2YS1jb250YWluZXJhbmFseXNpcy8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9 Copy-Tag: eyJwIjoiamF2YS1kYXRhZmxvdy8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9 Copy-Tag: eyJwIjoiamF2YS1kYXRhcHJvYy1tZXRhc3RvcmUvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ== Copy-Tag: eyJwIjoiamF2YS1kZWJ1Z2dlci1jbGllbnQvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ== Copy-Tag: eyJwIjoiamF2YS1kaWFsb2dmbG93LWN4Ly5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0= Copy-Tag: eyJwIjoiamF2YS1kaWFsb2dmbG93Ly5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0= Copy-Tag: eyJwIjoiamF2YS1kaXNjb3ZlcnllbmdpbmUvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ== Copy-Tag: eyJwIjoiamF2YS1kaXN0cmlidXRlZGNsb3VkZWRnZS8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9 Copy-Tag: eyJwIjoiamF2YS1kbHAvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ== Copy-Tag: eyJwIjoiamF2YS1kb2N1bWVudC1haS8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9 Copy-Tag: eyJwIjoiamF2YS1kb21haW5zLy5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0= Copy-Tag: eyJwIjoiamF2YS1lZGdlbmV0d29yay8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9 Copy-Tag: eyJwIjoiamF2YS1lbnRlcnByaXNla25vd2xlZGdlZ3JhcGgvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ== Copy-Tag: eyJwIjoiamF2YS1lcnJvcnJlcG9ydGluZy8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9 Copy-Tag: eyJwIjoiamF2YS1lc3NlbnRpYWwtY29udGFjdHMvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
e89d50d to
7cc0c9b
Compare
Contributor
I think that was incorrect as well. I think the unit tests were failing because of an outdated owlbot.lock image. Once #10304 was merged, the unit tests here passed. |
alicejli
approved these changes
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 607015517
Source-Link: googleapis/googleapis@c43e216
Source-Link: https://github.com/googleapis/googleapis-gen/commit/71c27adc96b0c80093b4a413815bd93943196bb2
Copy-Tag: eyJwIjoiamF2YS1jbG91ZGJ1aWxkLy5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0=
Copy-Tag: eyJwIjoiamF2YS1jbG91ZHF1b3Rhcy8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1jbG91ZHN1cHBvcnQvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1jb21wdXRlLy5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0=
Copy-Tag: eyJwIjoiamF2YS1jb250YWluZXIvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1jb250YWluZXJhbmFseXNpcy8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1kYXRhZmxvdy8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1kYXRhcHJvYy1tZXRhc3RvcmUvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1kZWJ1Z2dlci1jbGllbnQvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1kaWFsb2dmbG93LWN4Ly5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0=
Copy-Tag: eyJwIjoiamF2YS1kaWFsb2dmbG93Ly5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0=
Copy-Tag: eyJwIjoiamF2YS1kaXNjb3ZlcnllbmdpbmUvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1kaXN0cmlidXRlZGNsb3VkZWRnZS8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1kbHAvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1kb2N1bWVudC1haS8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1kb21haW5zLy5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0=
Copy-Tag: eyJwIjoiamF2YS1lZGdlbmV0d29yay8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1lbnRlcnByaXNla25vd2xlZGdlZ3JhcGgvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1lcnJvcnJlcG9ydGluZy8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1lc3NlbnRpYWwtY29udGFjdHMvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==