feat: pass thru OAuth audience during InstalledAppFlow.run_local_server#300
feat: pass thru OAuth audience during InstalledAppFlow.run_local_server#300clundin25 merged 2 commits intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
oh turns out my attempt to fill out the CLA failed because my organization has already signed one, I'll get myself added to the list |
|
ok I think I've joined the CLA google group for my org |
rseymour
left a comment
There was a problem hiding this comment.
Not a code owner but this would be a great fix!
|
@clundin25 what's the next step? can we get this approved? |
|
@clundin25 what's up with this "OwlBot Post Processor" status check? |
|
@keriwarr It just needs to be manually triggered. It should pass with no problem |
|
OwlBot is our friendly bot for keeping things in sync with the rest of our googleapis/ repos. It usually doesn't run for external contributors and forks, I've kicked off the job manually :) |
|
@keriwarr Can you confirm this code was needed so that the identity token had the correct audience? |
|
I will merge after @sai-sunder-s has taken a look as well. |
|
I will let this bake for a week and then cut a new release. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
442->445, but I think it's talking about the docstring?Fixes #299 🦕 (context in issue)