This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix: missing ssj for impersonate cred#1377
Merged
arithmetic1728 merged 1 commit intomainfrom Aug 31, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/294308809
For the impersonated credential, when the source cred is a service account and self signed jwt is enabled for source cred, after we create a copy of the source cred with IAM scopes, the source cred's internal _jwt_credential is lost so self signed jwt can no longer be used. We need to recreate one with the IAM scopes so self signed jwt can be used.