Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: Add smbios check to detect GCE residency#1276

Merged
wangyutongg merged 2 commits intomainfrom
yutong-gce-detection
Apr 28, 2023
Merged

feat: Add smbios check to detect GCE residency#1276
wangyutongg merged 2 commits intomainfrom
yutong-gce-detection

Conversation

@wangyutongg
Copy link
Contributor

Add static detection on Google hardware. Current detection on meta data server is not stable. For more details: go/auth-library-noping

Fixes: #1232

@wangyutongg wangyutongg marked this pull request as ready for review April 18, 2023 20:16
@wangyutongg wangyutongg requested review from a team April 18, 2023 20:16
@wangyutongg wangyutongg requested a review from a team as a code owner April 18, 2023 20:16
Copy link
Contributor

@clundin25 clundin25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits

@wangyutongg wangyutongg force-pushed the yutong-gce-detection branch from 7440f3f to ba206d7 Compare April 20, 2023 17:18
@arithmetic1728 arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2023
@arithmetic1728 arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2023
@wangyutongg wangyutongg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2023
@wangyutongg wangyutongg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2023
@wangyutongg wangyutongg force-pushed the yutong-gce-detection branch from 6a428bc to 34115f2 Compare April 28, 2023 01:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve GCE detection by checking Google hardware

4 participants