Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

Fix: Async certificate retrieving#1101

Merged
clundin25 merged 6 commits intogoogleapis:mainfrom
tivaliy:fix/async-certificate-retrieving
Aug 18, 2022
Merged

Fix: Async certificate retrieving#1101
clundin25 merged 6 commits intogoogleapis:mainfrom
tivaliy:fix/async-certificate-retrieving

Conversation

@tivaliy
Copy link
Copy Markdown
Contributor

@tivaliy tivaliy commented Aug 6, 2022

This PR fixes bug reported in #1100

@tivaliy tivaliy requested a review from a team August 6, 2022 11:20
@tivaliy tivaliy requested a review from a team as a code owner August 6, 2022 11:20
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 7, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 7, 2022
@clundin25
Copy link
Copy Markdown
Contributor

clundin25 commented Aug 15, 2022

Looks good. I have one minor outstanding comment.

Thanks for this contribution!

@clundin25 clundin25 added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 15, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 16, 2022
@clundin25 clundin25 added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2022
@clundin25 clundin25 added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 16, 2022
@clundin25 clundin25 added kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 18, 2022
@clundin25 clundin25 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 18, 2022
@clundin25 clundin25 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2022
@clundin25 clundin25 merged commit 05f125d into googleapis:main Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants