feat: add integration tests for pluggable auth#1073
feat: add integration tests for pluggable auth#1073clundin25 merged 8 commits intogoogleapis:mainfrom
Conversation
TimurSadykov
left a comment
There was a problem hiding this comment.
so far only comment request, in progress
TimurSadykov
left a comment
There was a problem hiding this comment.
LGTM, but please add comments to the test )
system_tests/noxfile.py
Outdated
| def external_accounts(session): | ||
| session.env[ALLOW_PLUGGABLE_ENV] = "1" | ||
| session.install( | ||
| *TEST_DEPENDENCIES_SYNC, |
There was a problem hiding this comment.
Does this need to change as well?
There was a problem hiding this comment.
Yes, without this environment variable set, pluggable auth tests will fail
There was a problem hiding this comment.
Sorry, I meant the test dependencies, only *TEST_DEPENDENCIES_SYNC was being used and I assumed they would need to be updated to *TEST_DEPENDENCIES_ASYNC to reflect the nox session change
There was a problem hiding this comment.
Ah, gotcha. I updated the nox session to use SYNC instead, because I believe Chuan updated the code to work with 2.7
There was a problem hiding this comment.
Seems like it failed with 2.7 :(
I don't have the context for this so I'm okay with moving it back to how you had it
|
|
No description provided.