fix: Validate url domain for aws metadata urls#1079
Merged
sai-sunder-s merged 4 commits intogoogleapis:mainfrom Nov 9, 2022
Merged
fix: Validate url domain for aws metadata urls#1079sai-sunder-s merged 4 commits intogoogleapis:mainfrom
sai-sunder-s merged 4 commits intogoogleapis:mainfrom
Conversation
TimurSadykov
approved these changes
Nov 8, 2022
TimurSadykov
left a comment
There was a problem hiding this comment.
LGTM with couple small comments
| try { | ||
| URL url = new URL(urlString); | ||
| String host = url.getHost(); | ||
| if (!host.equals("169.254.169.254") && !host.equals("[fd00:ec2::254]")) { |
There was a problem hiding this comment.
Both constants are GCE-specific, better add as package constants (static final) to the ComputeEngineCredentials
Contributor
Author
There was a problem hiding this comment.
They are AWS mds endpoints. 169.254.169.254 is same one used by GCE as well I guess. But I do not find any documentation about the ipv6 one for GCE
lsirac
approved these changes
Nov 8, 2022
TimurSadykov
pushed a commit
that referenced
this pull request
Nov 11, 2022
* fix: Validate url domain for aws metadata urls * fix external account tests * static method and split tests * rename param:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating AWS credential source validation as per new updates in AIP. Make sure the host of url, region_url and imdsv2 session token url belong to AWS metadata server.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.