Make apiclient.sample_tools optional #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theacodes
reviewed
Jun 4, 2018
apiclient/__init__.py
Outdated
| from googleapiclient import sample_tools | ||
| except ImportError: | ||
| import sys | ||
| sys.stderr.write("""Warning: unable to import apiclient.sample_tools\n""") |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
theacodes
reviewed
Jun 4, 2018
apiclient/__init__.py
Outdated
| 'schema': schema, | ||
| } | ||
|
|
||
| try: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
It depends heavily on oauth2client, which has been dropped as a required dependency
Contributor
Author
|
Thanks! Updated. |
theacodes
approved these changes
Jun 4, 2018
Contributor
|
Should there be a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It depends heavily on oauth2client, which has been dropped as a required dependency
This seems to me like the quickest way to tackle #524, but it feels ugly. Maybe
sample_toolsneeds to get re-written to usegoogle-auth?