Skip to content

fix: correct types param name for media mime-type#1602

Merged
JustinBeckwith merged 2 commits into
googleapis:masterfrom
AVaksman:correct_types_mediaUpload
Feb 19, 2019
Merged

fix: correct types param name for media mime-type#1602
JustinBeckwith merged 2 commits into
googleapis:masterfrom
AVaksman:correct_types_mediaUpload

Conversation

@AVaksman

Copy link
Copy Markdown
Contributor

Fixes #1598

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2019
@AVaksman

Copy link
Copy Markdown
Contributor Author

The failing docs test is addressed in PR #1603.

@codecov

codecov Bot commented Feb 19, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1602 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1602   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files           2        2           
  Lines         258      258           
  Branches        2        2           
=======================================
  Hits          254      254           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd4d79...f121e86. Read the comment docs.

@JustinBeckwith JustinBeckwith left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@JustinBeckwith JustinBeckwith merged commit 2a7af84 into googleapis:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants