feat(idtoken): add ParsePayload returning unvalidated token payload#2136
Merged
noahdietz merged 8 commits intogoogleapis:mainfrom Sep 14, 2023
Merged
feat(idtoken): add ParsePayload returning unvalidated token payload#2136noahdietz merged 8 commits intogoogleapis:mainfrom
noahdietz merged 8 commits intogoogleapis:mainfrom
Conversation
…rification. Also make the error message for token expiration slightly more informative. Both of these changes are made in order to improve debugability in cases where verification fails.
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Member
|
Please open an issue for discussion before making changes detailing the how/why for the feature request. |
Contributor
Author
|
Created #2137 |
noahdietz
requested changes
Sep 12, 2023
Contributor
noahdietz
left a comment
There was a problem hiding this comment.
Please add some tests as well, thanks.
Contributor
Author
|
Thanks Noah for the comment improvements. I will also add unit tests shortly. |
Contributor
Author
|
Added unit tests |
codyoss
reviewed
Sep 13, 2023
noahdietz
reviewed
Sep 13, 2023
…just function and some other minor fixes.
noahdietz
approved these changes
Sep 14, 2023
Contributor
|
LGTM @codyoss please stamp and I will get this into the next release (hopefully today!) |
codyoss
approved these changes
Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetPayloadattempts to parse the token and return the parsed payload from therein. It does not attempt toValidatethe token semantically or otherwise. This is especially useful for the case whereValidatefails and the user wants to inspect the payload directly (Validatedoesn't return the payload on failure currently).Also, improve the error message for token expiration by including the expiration time and the evaluated time.
Fixes #2137