Linkage Checker to examine linkage error at artifact level by suztomo · Pull Request #1032 · googleapis/gax-java

suztomo · 2020-05-06T15:33:39Z

Linkage Checker to examine linkage error at artifact level

gax-grpc has linkage errors caused by gRPC dependencies. The errors are suppressed by gax-grpc/linkage-checker-exclusion.xml.

codecov · 2020-05-06T15:36:31Z

Codecov Report

Merging #1032 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1032   +/-   ##
=========================================
  Coverage     78.76%   78.76%           
  Complexity     1171     1171           
=========================================
  Files           204      204           
  Lines          5180     5180           
  Branches        416      416           
=========================================
  Hits           4080     4080           
  Misses          925      925           
  Partials        175      175

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8d5ad0...4162f29. Read the comment docs.

suztomo · 2020-05-06T15:48:43Z

As part of linkage-monitor.sh script, new linkage checker tasks worked for each artifact:

...
> Task :gax:checkJavaLinkage
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

> Task :gax-grpc:checkJavaLinkage
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

> Task :gax-httpjson:checkJavaLinkage
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/4.9/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 16s

log

suztomo · 2020-05-06T16:05:12Z

@elharo @chingor13 PTAL.

elharo · 2020-05-06T16:48:03Z

@@ -0,0 +1,2 @@
+<?xml version="1.0" encoding="UTF-8"?>


couldn't we simply not have such a file here?

That would work. However the build.gradle would have if-statement to check whether the project is gax-grpc or not, to set the argument.

Removed these empty files in favor of the if-statement in build.gradle.

suztomo

@elharo PTAL.

suztomo · 2020-05-07T21:26:36Z

@@ -0,0 +1,2 @@
+<?xml version="1.0" encoding="UTF-8"?>


Removed these empty files in favor of the if-statement in build.gradle.

elharo · 2020-05-07T21:30:32Z

+        if (project.name == 'gax-grpc') {
+          // The exclusion file can be regenerated by '-o' option. See its Wiki for details:
+          // https://github.com/GoogleCloudPlatform/cloud-opensource-java/wiki/LinkageCheckerMain#exclusion-files
+          arguments += ['--exclusion-file', 'linkage-checker-exclusion.xml']


This makes me wonder if we really need to set the name and have a command line argument at all. Does it make sense to have a standard filename and location where the linkage checker looks?

elharo · 2020-05-12T20:05:41Z

What went wrong:
A problem occurred configuring root project 'gax-java'.

Could not resolve all artifacts for configuration ':classpath'.
Could not resolve net.ltgt.gradle:gradle-apt-plugin:0.10.
Required by:
project :
> Could not resolve net.ltgt.gradle:gradle-apt-plugin:0.10.
> Could not get resource 'https://plugins.gradle.org/m2/net/ltgt/gradle/gradle-apt-plugin/0.10/gradle-apt-plugin-0.10.pom'.
> Could not GET 'https://plugins.gradle.org/m2/net/ltgt/gradle/gradle-apt-plugin/0.10/gradle-apt-plugin-0.10.pom'.
> sun.security.validator.ValidatorException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed

Try:
Run with --stacktrace option to get th

suztomo · 2020-05-12T20:06:47Z

Java 7 from Kokoro

A problem occurred configuring root project 'gax-java'.
> Could not resolve all artifacts for configuration ':classpath'.
   > Could not resolve net.ltgt.gradle:gradle-apt-plugin:0.10.
     Required by:
         project :
      > Could not resolve net.ltgt.gradle:gradle-apt-plugin:0.10.
         > Could not get resource 'https://plugins.gradle.org/m2/net/ltgt/gradle/gradle-apt-plugin/0.10/gradle-apt-plugin-0.10.pom'.
            > Could not GET 'https://plugins.gradle.org/m2/net/ltgt/gradle/gradle-apt-plugin/0.10/gradle-apt-plugin-0.10.pom'.
               > sun.security.validator.ValidatorException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed

Somehow there was one successful Java 7 Kokoro build 73eadc5: https://source.cloud.google.com/results/invocations/bbaaac7f-a8dd-4310-8bb7-0ea02c74be11/targets/cloud-devrel%2Fclient-libraries%2Fjava%2Fgax-java%2Fpresubmit%2Fjava7/log

suztomo · 2020-05-21T19:55:00Z

@chingor13 @stephaniewang526 Would you update repository setting for "Required" check? I stopped Kokoro's checks for gax-java.

Remove Kokoro checks from "Required" checks
Mark the 4 GitHub Actions checks as "Required"

chingor13 · 2020-05-26T16:09:03Z

Updated the settings manually and will manage this repo's settings via our settings bot: googleapis/repo-automation-bots#565

suztomo added 5 commits April 13, 2020 14:44

test: testing linkge checker with Gradle

0486f79

linkage checker

8cab37d

Merge remote-tracking branch 'origin/master' into linkage_checker

0d4d0fd

Linkage Checker for gax, gax-grpc, gax-httpjson

4bd0a88

Added in kokoro shell script

906e4a3

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2020

Removed unnecessary change

cf7ec07

Reverting unnecessary change

425b92b

Added comment for exclusion file

73eadc5

elharo reviewed May 6, 2020

View reviewed changes

Exclusion file only for gax-grpc

9ccddd7

suztomo commented May 7, 2020

View reviewed changes

elharo approved these changes May 7, 2020

View reviewed changes

chingor13 approved these changes May 12, 2020

View reviewed changes

justinuang mentioned this pull request May 13, 2020

fix(logging): catch and log exceptions in Watchdog runnable to ensure it never stops running #1036

Merged

suztomo mentioned this pull request May 21, 2020

Adopt GitHub Actions in gax-java: unit tests and linkage monitor #1062

Merged

Merge remote-tracking branch 'origin/master' into linkage_checker

4162f29

chingor13 merged commit 28ec963 into googleapis:master May 26, 2020

chingor13 mentioned this pull request Jun 10, 2020

Release gax-java v1.57.0 #1127

Merged

Conversation

suztomo commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

suztomo commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suztomo commented May 6, 2020

Uh oh!

elharo May 6, 2020

Choose a reason for hiding this comment

Uh oh!

suztomo May 6, 2020

Choose a reason for hiding this comment

Uh oh!

suztomo May 7, 2020

Choose a reason for hiding this comment

Uh oh!

suztomo left a comment

Choose a reason for hiding this comment

Uh oh!

suztomo May 7, 2020

Choose a reason for hiding this comment

Uh oh!

elharo May 7, 2020

Choose a reason for hiding this comment

Uh oh!

elharo commented May 12, 2020

Uh oh!

suztomo commented May 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suztomo commented May 21, 2020

Uh oh!

chingor13 commented May 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

suztomo commented May 6, 2020 •

edited

Loading

codecov Bot commented May 6, 2020 •

edited

Loading

suztomo commented May 6, 2020 •

edited

Loading

suztomo commented May 12, 2020 •

edited

Loading