Don't exclude static local classes#1969
Merged
eamonnmcmanus merged 1 commit intogoogle:masterfrom Sep 18, 2021
Merged
Conversation
|
|
||
| if (isAnonymousOrLocal(clazz)) { | ||
| // Permit static local classes, such as Records (Java 16 feature) | ||
| if (!isStatic(clazz) && isAnonymousOrLocal(clazz)) { |
Member
There was a problem hiding this comment.
I am wondering if it makes sense for isAnonymousOrLocal to become isAnonymousOrLocalAndNotStatic. In the other case where we call the method (excludeField), would we want to accept static local classes as well?
Contributor
Author
There was a problem hiding this comment.
Ah, you are right excludeField should not exclude fields with static local classes as type either.
Moving it into isAnonymousOrLocal sounds good. What about isAnonymousOrNonStaticLocal as name instead?
Contributor
Author
There was a problem hiding this comment.
Have force-pushed the change. It now in theory also allows static anonymous classes (to not make the boolean expression too nested), but I don't think such a thing is possible in Java at the moment.
fca73eb to
0408b31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java 16 added Records, which can be declared locally but are always
static. It also allows interfaces to be declared locally.This pull request makes makes
Excluderallow such static local classes. Despite Gson not having a built-in adapter for Record types yet, it at least makes it easier for users to write their own, see #1794 (comment).The reason why local classes were previously not permitted seems to be that they can capture enclosing references which cannot be serialized and deserialized properly, see #298. However for
staticclasses this won't be an issue.I have not added a test for this because Gson currently uses Java 6 to compile, so it would require adjustments to the Maven build to support compiling and running one test with Java 16. With Maven this is slightly more cumbersome than with Gradle because users need to manually set up a toolchain to specify a Java 16 JDK, whereas Gradle can handle that on its own.
But you can test this manually by running:
Relates to #1510