This repository was archived by the owner on Nov 20, 2025. It is now read-only.
refactor(deps): use gaxios for HTTP requests instead of axios#593
Merged
JustinBeckwith merged 3 commits intogoogleapis:masterfrom Jan 15, 2019
Merged
Conversation
JustinBeckwith
suggested changes
Jan 15, 2019
JustinBeckwith
approved these changes
Jan 15, 2019
Contributor
JustinBeckwith
left a comment
There was a problem hiding this comment.
THIS IS EXCITING.
| access_token: 'initial-access-token', | ||
| refresh_token: 'refresh-token-placeholder' | ||
| refresh_token: 'refresh-token-placeholder', | ||
| expiry_date: (new Date()).getTime() + 500000 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
gaxios for HTTP requests instead of axios
Contributor
Author
|
Tested with several of the client libs as well. BigQuery, Bigtable, Compute, DNS, Logging, Storage to name a fewveral. |
Contributor
|
And it worked!? |
Contributor
Author
|
Yep! And the proxy test script I've been using. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches from Axios to Gaxios. Hopefully nobody notices.