Skip to content

Support temporary private fork creation via API#3025

Merged
gmlewis merged 2 commits intogoogle:masterfrom
Kiyo510:feature/add-temporary-private-fork-creation
Dec 15, 2023
Merged

Support temporary private fork creation via API#3025
gmlewis merged 2 commits intogoogle:masterfrom
Kiyo510:feature/add-temporary-private-fork-creation

Conversation

@Kiyo510
Copy link
Copy Markdown
Contributor

@Kiyo510 Kiyo510 commented Dec 9, 2023

resolved: #3007

@google-cla
Copy link
Copy Markdown

google-cla bot commented Dec 9, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 9, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (062b611) 97.91% compared to head (2a18902) 97.89%.
Report is 2 commits behind head on master.

Files Patch % Lines
github/security_advisories.go 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3025      +/-   ##
==========================================
- Coverage   97.91%   97.89%   -0.03%     
==========================================
  Files         150      150              
  Lines       12980    12997      +17     
==========================================
+ Hits        12710    12724      +14     
- Misses        192      194       +2     
- Partials       78       79       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gmlewis
gmlewis requested changes Dec 9, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Kiyo510 !
One minor nit, please, and then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Dec 9, 2023
@Kiyo510 @gmlewis
Update github/security_advisories.go
2a18902 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@Kiyo510
Copy link
Copy Markdown
Contributor Author

Kiyo510 commented Dec 10, 2023

@gmlewis
Thanks for reviewing my PR.
Since I made a modification, please check it out again.

@Kiyo510 Kiyo510 requested a review from gmlewis December 10, 2023 10:11
gmlewis
gmlewis approved these changes Dec 10, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Kiyo510 !
LGTM.

Awaiting a second LGTM+Approval from any other contributor to this repo before merging.

valbeat
valbeat approved these changes Dec 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 15, 2023
@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Dec 15, 2023

Thank you, @valbeat !
Merging.

@gmlewis gmlewis merged commit 37f1826 into google:master Dec 15, 2023
@Kiyo510 Kiyo510 deleted the feature/add-temporary-private-fork-creation branch December 16, 2023 13:57
gmlewis pushed a commit to WillAbides/go-github that referenced this pull request Dec 18, 2023
@Kiyo510 @gmlewis
Support temporary private fork creation via API (google#3025)
574f3a7 
Fixes: google#3007.
gmlewis pushed a commit to o-sama/go-github that referenced this pull request Dec 19, 2023
@Kiyo510 @gmlewis
Support temporary private fork creation via API (google#3025)
f53e74d 
Fixes: google#3007.
@gmlewis gmlewis mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

+1 more reviewer

@valbeat valbeat valbeat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support temporary private fork creation via API

3 participants

@Kiyo510 @gmlewis @valbeat