Skip to content

Add code_search and dependency_snapshots for RateLimits#3019

Merged
gmlewis merged 5 commits intogoogle:masterfrom
rufusnufus:master
Dec 15, 2023
Merged

Add code_search and dependency_snapshots for RateLimits#3019
gmlewis merged 5 commits intogoogle:masterfrom
rufusnufus:master

Conversation

@rufusnufus
Copy link
Copy Markdown
Contributor

@rufusnufus rufusnufus commented Dec 5, 2023

resolves #3018

@google-cla
Copy link
Copy Markdown

google-cla bot commented Dec 5, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rufusnufus rufusnufus marked this pull request as draft December 5, 2023 23:13
@rufusnufus rufusnufus marked this pull request as ready for review December 5, 2023 23:26
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb8a83d) 97.91% compared to head (bc30e10) 97.92%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3019   +/-   ##
=======================================
  Coverage   97.91%   97.92%           
=======================================
  Files         150      150           
  Lines       12980    12990   +10     
=======================================
+ Hits        12710    12720   +10     
  Misses        192      192           
  Partials       78       78

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gmlewis
gmlewis approved these changes Dec 6, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rufusnufus !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Dec 6, 2023
valbeat
valbeat approved these changes Dec 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 15, 2023
@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Dec 15, 2023

Thank you, @valbeat !
Merging after tests pass.

@gmlewis gmlewis merged commit 2cc47f9 into google:master Dec 15, 2023
gmlewis pushed a commit to WillAbides/go-github that referenced this pull request Dec 18, 2023
@rufusnufus @gmlewis
Add code_search and dependency_snapshots for RateLimits (google#3019)
d6af4c8 
Fixes: google#3018.
gmlewis pushed a commit to o-sama/go-github that referenced this pull request Dec 19, 2023
@rufusnufus @gmlewis
Add code_search and dependency_snapshots for RateLimits (google#3019)
f5b837b 
Fixes: google#3018.
@gmlewis gmlewis mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

+1 more reviewer

@valbeat valbeat valbeat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for code_search and dependency_snapshots for RateLimits

3 participants

@rufusnufus @gmlewis @valbeat