Add SAML SSO audit log fields#2941
Merged
gmlewis merged 2 commits intogoogle:masterfrom Sep 29, 2023
patriknordlen:add-saml-sso-audit-log-fields
Merged
Add SAML SSO audit log fields#2941gmlewis merged 2 commits intogoogle:masterfrom patriknordlen:add-saml-sso-audit-log-fields
gmlewis merged 2 commits intogoogle:masterfrom
patriknordlen:add-saml-sso-audit-log-fields
Conversation
gmlewis
approved these changes
Sep 29, 2023
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @patriknordlen !
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the new fields ExternalIdentityNameID and ExternalIdentityUsername to the AuditEntry struct. These are new fields emitted in GitHub audit logs that allow organizations and enterprises to track a user's attached SAML SSO identity in audit log events. See the announcement and slightly more technical details in the community discussion page.