Add missing secret scanning alert fields#2930
Merged
gmlewis merged 2 commits intogoogle:masterfrom Sep 18, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2930 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 143 143
Lines 12609 12609
=======================================
Hits 12379 12379
Misses 156 156
Partials 74 74
|
WillAbides
approved these changes
Sep 15, 2023
Contributor
WillAbides
left a comment
There was a problem hiding this comment.
LGTM. The lint failure is a timeout. I verified locally that lint passes on this branch, but somebody with permissions will need to trigger re-running the action.
gmlewis
approved these changes
Sep 18, 2023
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @vandanrohatgi and @WillAbides !
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2929