Fix serialization of repository_names conditions object#2910
Merged
gmlewis merged 1 commit intogoogle:masterfrom Sep 4, 2023
Merged
Fix serialization of repository_names conditions object#2910gmlewis merged 1 commit intogoogle:masterfrom
gmlewis merged 1 commit intogoogle:masterfrom
Conversation
RulesetRepositoryNamesConditionParameters Include and Exclude shall not be omitted
Codecov Report
@@ Coverage Diff @@
## master #2910 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 142 142
Lines 12453 12453
=======================================
Hits 12219 12219
Misses 159 159
Partials 75 75
|
WillAbides
approved these changes
Sep 4, 2023
Collaborator
|
Thank you, @WillAbides ! |
gmlewis
pushed a commit
to gmlewis/go-github
that referenced
this pull request
Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RulesetRepositoryNamesConditionParameters, Include and Exclude fields shall not be omitted when empty.Fixes: #2909