Return json.Unmarshal error when importing issues deferred#2892
Merged
gmlewis merged 2 commits intogoogle:masterfrom Aug 22, 2023
Merged
Return json.Unmarshal error when importing issues deferred#2892gmlewis merged 2 commits intogoogle:masterfrom
gmlewis merged 2 commits intogoogle:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2892 +/- ##
==========================================
+ Coverage 98.06% 98.10% +0.04%
==========================================
Files 140 142 +2
Lines 12269 12340 +71
==========================================
+ Hits 12031 12106 +75
+ Misses 162 159 -3
+ Partials 76 75 -1
|
gmlewis
requested changes
Aug 21, 2023
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @nikpivkin !
Could you please add a test case that demonstrates the problem?
In the past, I've found it really handy to demonstrate json.Unmarshal errors by forcing the data to be something bogus for JSON like {].
Contributor
Author
|
@gmlewis Hi! Fixed! The initial fix was that the error did not return when the response status was 202. (nil returned) |
gmlewis
approved these changes
Aug 21, 2023
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @nikpivkin !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
gabriel-samfira
approved these changes
Aug 22, 2023
Collaborator
|
Thank you, @gabriel-samfira ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error was not returned when the 202 status was received during the issues import.