Fix old_name field in AuditEntry#2849
Merged
gmlewis merged 7 commits intogoogle:masterfrom Jul 28, 2023
lmartinking:patch-2
Merged
Fix old_name field in AuditEntry#2849gmlewis merged 7 commits intogoogle:masterfrom lmartinking:patch-2
old_name field in AuditEntry#2849gmlewis merged 7 commits intogoogle:masterfrom
lmartinking:patch-2
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2849 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 138 138
Lines 12318 12318
=======================================
Hits 12080 12080
Misses 162 162
Partials 76 76
|
gmlewis
requested changes
Jul 28, 2023
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @lmartinking !
Now worries. I'm glad you caught it before I cut the new release. 😄
Contributor
Author
|
@gmlewis I have one more field to add, which I will do in another PR |
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Contributor
Author
|
@gmlewis do you want the structs to mirror the shape of the API or would you prefer it flattened? Which was why I had it as a composite member. |
Collaborator
We typically do not use composite members in this repo. |
gmlewis
approved these changes
Jul 28, 2023
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @lmartinking !
LGTM.
Merging.
old_name field in AuditEntry is incorrectly mapped from the JSON returned by the Audit Log APIold_name field in AuditEntry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Much to my chagrin, the audit log view in the site manager does not follow the shape of the API response.
I previously raised a PR #2843 which was merged yesterday. Unfortunately, it does not work with the payload returned from the API.
My sincere apologies about this.