Implement rulesets#2795
Merged
gmlewis merged 39 commits intogoogle:masterfrom Jun 17, 2023
liaodaniel:add_ruleset
Merged
Conversation
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Closed
Codecov Report
@@ Coverage Diff @@
## master #2795 +/- ##
==========================================
+ Coverage 98.06% 98.10% +0.04%
==========================================
Files 132 134 +2
Lines 11650 11947 +297
==========================================
+ Hits 11424 11721 +297
Misses 154 154
Partials 72 72
|
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Contributor
Author
|
Linter appears to be failing due to golangci/golangci-lint#3862. Guess I'll wait until they make a fix for it |
gmlewis
requested changes
Jun 2, 2023
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @liaodaniel !
This looks fantastic! I have just a few change requests, and feel free to disagree on any of them. As I commented, it is challenging to tell if we have the right combination of omitempty, but this looks good to me if I haven't made comments otherwise.
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
gmlewis
approved these changes
Jun 7, 2023
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @liaodaniel !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Collaborator
|
Thank you, @valbeat ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes both the organization and repository rulesets API.
Resolves #2789
Signed-off-by: Daniel Liao 10663736+liaodaniel@users.noreply.github.com