Add test for resource JSON marshaling#2783
Merged
gmlewis merged 1 commit intogoogle:masterfrom May 17, 2023
Merged
Conversation
Contributor
Author
|
Perfect, for the next time, is it okay to accumulate a bunch of commits and create a bundled PR then or would you prefer them smaller? |
Collaborator
For #55, feel free to make a larger PR with a bunch of commits... we always squash+merge in this repo anyway. In general, if an issue is complex, multiple PRs are nice, but not necessary... but feel free to make a huge one for #55. Also, you can wait to actually make the PR until you are ready for a code review. Thanks, @kldzj ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is #55 still actively pursued?
Adds test for JSON marshalling specifically the
RepositoryTagresource.