Add test case for JSON resource marshaling #2543
Merged
gmlewis merged 6 commits intogoogle:masterfrom Oct 28, 2022
Merged
Conversation
gmlewis
requested changes
Oct 28, 2022
…to search_test_CommitResult
…rmore/go-github into search_test_CommitResult
Codecov Report
@@ Coverage Diff @@
## master #2543 +/- ##
=======================================
Coverage 97.97% 97.97%
=======================================
Files 123 123
Lines 10813 10813
=======================================
Hits 10594 10594
Misses 150 150
Partials 69 69 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gmlewis
reviewed
Oct 28, 2022
| Commit: &Commit{SHA: String("test")}, | ||
| Author: &User{ID: Int64(1)}, | ||
| Committer: &User{ID: Int64(1)}, | ||
| Parents: []*Commit{}, |
Collaborator
There was a problem hiding this comment.
Any reason for not supplying a single parent?
Collaborator
There was a problem hiding this comment.
Never mind, let's get this in before I go OOO.
Contributor
Author
There was a problem hiding this comment.
it's just an omitempty so I want to try to ignore this. But Thanks @gmlewis for approving :)
gmlewis
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi creator,
Added test cases for JSON Resources :
CommitResult
Helps: #55
I have followed all the guidelines to contribute to this repository.
Please revert in case of any changes are needed.
I am a first-time contributor to Hackoctober, It will be a great help if u can encourage me & accept my contribution.