Add test case for JSON resource marshaling #2526
Merged
gmlewis merged 1 commit intogoogle:masterfrom Oct 25, 2022
Merged
Conversation
gmlewis
approved these changes
Oct 25, 2022
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @vaibhavgholap23 !
LGTM.
Merging.
Codecov Report
@@ Coverage Diff @@
## master #2526 +/- ##
==========================================
- Coverage 98.03% 97.97% -0.07%
==========================================
Files 122 123 +1
Lines 10705 10813 +108
==========================================
+ Hits 10495 10594 +99
- Misses 144 150 +6
- Partials 66 69 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
|
Please ignore the above Codecov Report, as it is clearly wrong. |
Harikesh00
pushed a commit
to Harikesh00/go-github
that referenced
this pull request
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi creators,
I have added test cases for :
SCIMUserName struct
under Helps: #55 issue
I have followed all the guidelines to contribute to this repository.
Please revert in case of any changes are needed.
I am a first-time contributor to Hackoctober, It will be great if you review & accept my contribution.