Skip to content

Add test cases for JSON resource marshaling#2520

Merged
gmlewis merged 10 commits intogoogle:masterfrom
Harikesh00:repos-test-marshal
Oct 26, 2022
Merged

Add test cases for JSON resource marshaling#2520
gmlewis merged 10 commits intogoogle:masterfrom
Harikesh00:repos-test-marshal

Conversation

@Harikesh00
Copy link
Copy Markdown
Contributor

@Harikesh00 Harikesh00 commented Oct 25, 2022

Added test cases for DispatchRequestOptions, TransferRequest, SignaturesProtectedBranch, DismissalRestrictionsRequest of file github/repos.go

contribution to #55

@Harikesh00 Harikesh00 mentioned this pull request Oct 25, 2022
Closed
@gmlewis gmlewis changed the title Added test cases for JSON resource marshaling Add test cases for JSON resource marshaling Oct 25, 2022
gmlewis
gmlewis requested changes Oct 25, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Harikesh00 !

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Oct 25, 2022

@Harikesh00 - do you want Hacktoberfest credit for this one? If so, please add to the description in future PRs. Thank you!

@Harikesh00
Copy link
Copy Markdown
Contributor Author

Harikesh00 commented Oct 25, 2022

yes @gmlewis. I want this for Hacktoberfest, kindly add the label for same

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 25, 2022 •
edited
Loading

Codecov Report

Merging #2520 (bb208c1) into master (9b60dfb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2520   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files         123      123           
  Lines       10813    10813           
=======================================
  Hits        10594    10594           
  Misses        150      150           
  Partials       69       69

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gmlewis
gmlewis requested changes Oct 25, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for consistency sake, could you please add in the whitespace to all the want strings that the standard Go json.MarshalIndent would add so that all our JSON examples look the same?

@Harikesh00
Copy link
Copy Markdown
Contributor Author

Harikesh00 commented Oct 26, 2022

spaces added
plz check

gmlewis
gmlewis approved these changes Oct 26, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Harikesh00 !
LGTM.
Merging.

@gmlewis gmlewis merged commit f9d2c6b into google:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Harikesh00 @gmlewis