InstallationPermissions: organization perms#2452
Merged
gmlewis merged 1 commit intogoogle:masterfrom Sep 7, 2022
thepwagner:install-permissions-organization-packages
Merged
InstallationPermissions: organization perms#2452gmlewis merged 1 commit intogoogle:masterfrom thepwagner:install-permissions-organization-packages
gmlewis merged 1 commit intogoogle:masterfrom
thepwagner:install-permissions-organization-packages
Conversation
Add `organization_custom_roles` and `organization_packages` as available permissions, per https://docs.github.com/en/rest/apps/apps#create-an-installation-access-token-for-an-app Signed-off-by: Peter Wagner <1559510+thepwagner@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #2452 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 122 122
Lines 10689 10689
=======================================
Hits 10479 10479
Misses 144 144
Partials 66 66
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gmlewis
approved these changes
Sep 7, 2022
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @thepwagner !
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
organization_custom_rolesandorganization_packagesas available permissions on theInstallPermissionsstruct, per https://docs.github.com/en/rest/apps/apps#create-an-installation-access-token-for-an-appI've functionally tested the
organization_custom_rolesbit, but I'm not sure how to verifyorganization_packages. It is documented online and in other libraries like octokit: https://github.com/search?q=org%3Aoctokit+organization_packages&type=code , but I can't add it to a test GitHub.com app. It may only be available on GitHub Enterprise? 🤷