feature: adding api and web to meta api endpoint.#2435
feature: adding api and web to meta api endpoint.#2435gmlewis merged 3 commits intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
@@ Coverage Diff @@
## master #2435 +/- ##
=======================================
Coverage 98.08% 98.08%
=======================================
Files 122 122
Lines 10632 10632
=======================================
Hits 10428 10428
Misses 140 140
Partials 64 64
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@gmlewis Hey, thanks for the feedback. I have made the changes and sorted the CLA out. 👍 |
|
Thanks, @Jamian ! I think the tests might need updating, please. |
|
Hey @gmlewis, of course - awkwardly embarrassing! Just pushed the fixes to get tests passing 🤞 |
The Api and Web lists are returned from the
metaAPI but still aren't supported in the Go library. This change exposes them in the same way as the other blocks which are returned. I'm working on a change in the GitHub Terraform provider to also support exposing these API/Web CIDRs so if this is all ok I can continue on with that change as well.