Add hooks support for WebSub (formerly PubSubHubbub) protocol#2397
Add hooks support for WebSub (formerly PubSubHubbub) protocol#2397gmlewis merged 3 commits intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
@@ Coverage Diff @@
## master #2397 +/- ##
==========================================
- Coverage 98.06% 98.04% -0.02%
==========================================
Files 119 119
Lines 10546 10597 +51
==========================================
+ Hits 10342 10390 +48
- Misses 140 142 +2
- Partials 64 65 +1
Continue to review full report at Codecov.
|
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
raynigon
left a comment
There was a problem hiding this comment.
Can be merged, but it would be nice if the error case test gets added first.
resolves #1265
Note: PubSubHubbub seems to have been renamed WebSub when it was adopted by the W3C. So we use the name WebSub in our code.
ref https://github.com/pubsubhubbub/PubSubHubbub
Added support for API to subscribe and unsubscribe to repository events via WebSub protocol.
GitHub API Docs: https://docs.github.com/en/rest/webhooks#pubsubhubbub
WebSub Docs: https://www.w3.org/TR/websub/
WebSub requires Content-Type to be application/x-www-form-urlencoded, so a new factory function has been added.