deprecate estargz#1660
Merged
imjasonh merged 3 commits intogoogle:mainfrom Apr 19, 2023
Merged
Conversation
330b78f to
e03a4de
Compare
Codecov Report
@@ Coverage Diff @@
## main #1660 +/- ##
==========================================
+ Coverage 72.11% 72.13% +0.02%
==========================================
Files 120 120
Lines 9814 9815 +1
==========================================
+ Hits 7077 7080 +3
+ Misses 2015 2014 -1
+ Partials 722 721 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jonjohnsonjr
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's unclear whether this is practically taken advantage of at runtime, since it's relatively hard to run the estargz snapshotter.
There are some callers of this method out in the wild: https://github.com/search?type=code&auto_enroll=true&q=tarball.WithEstargz
If this is useful to others it may make sense to fork it into a separate repo that's capable of producing layers with estargz-optimized tarballs, but this probably isn't something we're going to maintain going forward.
This also removes the previously-hidden
crane optimizecommand, andcrane.Optimize, which had a big scary warning about it changing without warning.crane optimizeonly seems to be used in forks of Matt'sminkrepo, andcrane.Optimizeonly seems to be used in forks of ggcr.